Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unison-ucm: 1.0.M1j-alpha -> 1.0.M1l-alpha #86150

Merged
merged 1 commit into from Apr 29, 2020
Merged

unison-ucm: 1.0.M1j-alpha -> 1.0.M1l-alpha #86150

merged 1 commit into from Apr 29, 2020

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Apr 27, 2020 •
edited

Motivation for this change

Follow-up to #85940. There were a couple of issues with the
1.0.M1j-alpha release that were promptly fixed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from virusdave April 27, 2020 22:22
worldofpeace
worldofpeace suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't change the version to M1l in the commit.

@ceedubs
unison-ucm: 1.0.M1j-alpha -> 1.0.M1l-alpha
df202b4 
Follow-up to NixOS#85940. There were a couple of issues with the
1.0.M1j-alpha release that were promptly fixed.
@ceedubs ceedubs changed the title unison-ucm: 1.0.M1j-alpha -> 1.0.M1j-alpha unison-ucm: 1.0.M1j-alpha -> 1.0.M1l-alpha Apr 28, 2020
@ceedubs
Copy link
Contributor Author

ceedubs commented Apr 28, 2020

@worldofpeace ugh nice catch; sorry about that. I force-pushed a change to the commit message (and also changed the PR title).

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build unison-ucm

@worldofpeace worldofpeace merged commit b7f80f0 into NixOS:master Apr 29, 2020
@ceedubs ceedubs deleted the unison-ucm-M1l branch May 22, 2020 14:10
@ceedubs ceedubs mentioned this pull request Oct 8, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@virusdave virusdave virusdave approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ceedubs @worldofpeace @virusdave