Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python27Packages.watchdog: 0.9.0 -> 0.10.2 #86625

Merged
merged 1 commit into from May 6, 2020

Conversation

@bhipple
Copy link
Contributor

bhipple commented May 3, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-watchdog/versions.

meta.description for python27Packages.watchdog is: "Python API and shell utilities to monitor file system events"

meta.homepage for python27Packages.watchdog is: "https://github.com/gorakhargosh/watchdog"

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • Warning: a test defined in passthru.tests did not pass

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 0.10.2 with grep in /nix/store/r16qy3rbpmszw8k2rwv4zjcdkkw12inx-python2.7-watchdog-0.10.2


Rebuild report (if merged into master) (click to expand)

Instructions to test this update (click to expand)

Build yourself:

nix-build -A python27Packages.watchdog https://github.com/r-ryantm/nixpkgs/archive/fb13f035f3994082edd1f38475f69a974a2e9d75.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/r16qy3rbpmszw8k2rwv4zjcdkkw12inx-python2.7-watchdog-0.10.2
ls -la /nix/store/r16qy3rbpmszw8k2rwv4zjcdkkw12inx-python2.7-watchdog-0.10.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

2 packages failed to build:
- hovercraft
- topydo
55 packages built:
- buildbot (python37Packages.buildbot)
- buildbot-full (python37Packages.buildbot-full)
- buildbot-ui (python37Packages.buildbot-ui)
- datasette (python37Packages.datasette)
- devpi-client
- devpi-server
- maestral
- maestral-gui
- markdown-pp
- pympress
- python27Packages.easywatch
- python27Packages.hupper
- python27Packages.lektor
- python27Packages.pytest-watch
- python27Packages.staticjinja
- python27Packages.watchdog
- python37Packages.Nikola
- python37Packages.cornice
- python37Packages.easywatch
- python37Packages.hupper
- python37Packages.lektor
- python37Packages.pyjade
- python37Packages.pyramid
- python37Packages.pyramid_beaker
- python37Packages.pyramid_chameleon
- python37Packages.pyramid_exclog
- python37Packages.pyramid_hawkauth
- python37Packages.pyramid_jinja2
- python37Packages.pyramid_mako
- python37Packages.pyramid_multiauth
- python37Packages.pytest-watch
- python37Packages.sentry-sdk
- spyder (python37Packages.spyder)
- python37Packages.staticjinja
- python37Packages.watchdog
- python38Packages.buildbot
- python38Packages.buildbot-full
- python38Packages.buildbot-ui
- python38Packages.cornice
- python38Packages.easywatch
- python38Packages.hupper
- python38Packages.lektor
- python38Packages.pyjade
- python38Packages.pyramid
- python38Packages.pyramid_beaker
- python38Packages.pyramid_chameleon
- python38Packages.pyramid_exclog
- python38Packages.pyramid_hawkauth
- python38Packages.pyramid_jinja2
- python38Packages.pyramid_mako
- python38Packages.pyramid_multiauth
- python38Packages.pytest-watch
- python38Packages.staticjinja
- python38Packages.watchdog
- streamlit

Maintainer pings

cc @cillianderoiste for testing.

@bhipple bhipple requested review from FRidh and jonringer as code owners May 3, 2020
bhipple added a commit to bhipple/nixpkgs-update that referenced this pull request May 3, 2020
1. We should always use `~/.cache/nixpkgs`, since if we do it in PWD the hard
resets risk blowing away user work!

2. Previously, we weren't fetching and resetting to up-to-date master, which
   meant cmds would fail if your nixpkgs checkout was stale.

3. Previously, we were ignoring the `--pr` option entirely. This fixes that bug
by passing the bool into the UpdateEnv, and also cleans up the selected options
in the logger so it's easier to see.

4. We were including the title PR twice, like this:
   NixOS/nixpkgs#86624

There are still some issues and things to improve, but with this PR I've managed
to get a working usage here:
NixOS/nixpkgs#86625
@ofborg ofborg bot added the 6.topic: python label May 3, 2020
@ofborg ofborg bot requested a review from cillianderoiste May 3, 2020
Copy link
Contributor

jonringer left a comment

getting a few regressions, the biggest being python3Packages.hupper

20 packages failed to build:
buildbot buildbot-full buildbot-ui datasette devpi-client devpi-server hovercraft python37Packages.cornice python37Packages.hupper python37Packages.pyjade python37Packages.pyramid python37Packages.pyramid_beaker python37Packages.pyramid_chameleon python37Packages.pyramid_exclog python37Packages.pyramid_hawkauth python37Packages.pyramid_jinja2 python37Packages.pyramid_mako python37Packages.pyramid_multiauth python37Packages.sentry-sdk topydo

37 packages built:
maestral maestral-gui markdown-pp pympress python27Packages.easywatch python27Packages.hupper python27Packages.lektor python27Packages.pytest-watch python27Packages.staticjinja python27Packages.watchdog python37Packages.Nikola python37Packages.easywatch python37Packages.lektor python37Packages.pytest-watch spyder python37Packages.staticjinja python37Packages.watchdog python38Packages.buildbot python38Packages.buildbot-full python38Packages.buildbot-ui python38Packages.cornice python38Packages.easywatch python38Packages.hupper python38Packages.lektor python38Packages.pyjade python38Packages.pyramid python38Packages.pyramid_beaker python38Packages.pyramid_chameleon python38Packages.pyramid_exclog python38Packages.pyramid_hawkauth python38Packages.pyramid_jinja2 python38Packages.pyramid_mako python38Packages.pyramid_multiauth python38Packages.pytest-watch python38Packages.staticjinja python38Packages.watchdog streamlit
@bhipple
Copy link
Contributor Author

bhipple commented May 6, 2020

Are you sure that was for this PR? Re-running nixpkgs-review still just gives me the same two failures as in the PR description, both of which have been failing on master for some time.

Copy link
Contributor

jonringer left a comment

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/86625
4 package failed to build:
hovercraft python37Packages.Nikola spyder topydo

53 package built:
buildbot buildbot-full buildbot-ui datasette devpi-client devpi-server maestral maestral-gui markdown-pp pympress python27Packages.easywatch python27Packages.hupper python27Packages.lektor python27Packages.pytest-watch python27Packages.staticjinja python27Packages.watchdog python37Packages.cornice python37Packages.easywatch python37Packages.hupper python37Packages.lektor python37Packages.pyjade python37Packages.pyramid python37Packages.pyramid_beaker python37Packages.pyramid_chameleon python37Packages.pyramid_exclog python37Packages.pyramid_hawkauth python37Packages.pyramid_jinja2 python37Packages.pyramid_mako python37Packages.pyramid_multiauth python37Packages.pytest-watch python37Packages.sentry-sdk python37Packages.staticjinja python37Packages.watchdog python38Packages.buildbot python38Packages.buildbot-full python38Packages.buildbot-ui python38Packages.cornice python38Packages.easywatch python38Packages.hupper python38Packages.lektor python38Packages.pyjade python38Packages.pyramid python38Packages.pyramid_beaker python38Packages.pyramid_chameleon python38Packages.pyramid_exclog python38Packages.pyramid_hawkauth python38Packages.pyramid_jinja2 python38Packages.pyramid_mako python38Packages.pyramid_multiauth python38Packages.pytest-watch python38Packages.staticjinja python38Packages.watchdog streamlit
@jonringer jonringer merged commit 0a169d1 into NixOS:master May 6, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb13f03"; rev="fb13f035f3994082edd1f38475f69a974a2e9d75"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb13f03"; rev="fb13f035f3994082edd1f38475f69a974a2e9d75"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb13f03"; rev="fb13f035f3994082edd1f38475f69a974a2e9d75"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb13f03"; rev="fb13f035f3994082edd1f38475f69a974a2e9d75"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb13f03"; rev="fb13f035f3994082edd1f38475f69a974a2e9d75"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb13f03"; rev="fb13f035f3994082edd1f38475f69a974a2e9d75"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb13f03"; rev="fb13f035f3994082edd1f38475f69a974a2e9d75"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.watchdog, python27Packages.watchdog.passthru.tests on aarch64-linux Success
Details
python27Packages.watchdog, python27Packages.watchdog.passthru.tests on x86_64-linux Success
Details
@jonringer
Copy link
Contributor

jonringer commented May 6, 2020

not sure what happened, maybe they were fixed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.