Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-tarpaulin: init at 0.12.4 #87571

Merged
merged 1 commit into from May 14, 2020
Merged

cargo-tarpaulin: init at 0.12.4 #87571

merged 1 commit into from May 14, 2020

Conversation

@HugoReeves
Copy link
Contributor

HugoReeves commented May 11, 2020

Motivation for this change

Init cargo-tarpaulin. Tarpaulin is used to calculate line based code coverage of Rust projects. It's a tool in use by multiple prominent rust projects.
Builds and executes successfully on NixOS.
Currently, the cargo test step for the derivation is disabled. checkPhase = null. Some of the tests were failing, I believe this issue is due to the incorrect tests being run. It would be appreciated if someone familiar with the nixpkgs rustPlatform could suggest a way to fix this issue with the derivation build.
The result of the build still functions properly, however it would be nice to enable tests so that future updates can be tested thoroughly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@HugoReeves
Copy link
Contributor Author

HugoReeves commented May 14, 2020

@srhb Made the corrections. I couldn't get the tests to pass with the recommended args. Revised commit builds on NixOS.

@srhb srhb merged commit 2bf4a22 into NixOS:master May 14, 2020
16 checks passed
16 checks passed
cargo-tarpaulin, cargo-tarpaulin.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
cargo-tarpaulin, cargo-tarpaulin.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81b7c93"; rev="81b7c9368c2381d40b0f6967f2ab633c3e4fc014"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81b7c93"; rev="81b7c9368c2381d40b0f6967f2ab633c3e4fc014"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81b7c93"; rev="81b7c9368c2381d40b0f6967f2ab633c3e4fc014"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81b7c93"; rev="81b7c9368c2381d40b0f6967f2ab633c3e4fc014"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81b7c93"; rev="81b7c9368c2381d40b0f6967f2ab633c3e4fc014"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81b7c93"; rev="81b7c9368c2381d40b0f6967f2ab633c3e4fc014"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81b7c93"; rev="81b7c9368c2381d40b0f6967f2ab633c3e4fc014"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.