Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_stylus: updated broken icon hash #87801

Closed
wants to merge 1 commit into from

Conversation

@remunds
Copy link

remunds commented May 14, 2020

Motivation for this change

Hash was broken.

Things done

Changed hash accordingly

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.
Copy link
Contributor

oyren left a comment

No idea what happened but for me the old hash works but the new one does not.

@remunds
Copy link
Author

remunds commented May 17, 2020

Kinda weird. Now the old one works for me aswell. Maybe the download link was down or something. Whatever, problem resolved.

@remunds remunds closed this May 17, 2020
@remunds remunds deleted the remunds:fix/write_stylus branch May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.