Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mariadb: 10.4.12 -> 10.4.13 #87878

Merged
merged 6 commits into from Jun 5, 2020
Merged

mariadb: 10.4.12 -> 10.4.13 #87878

merged 6 commits into from Jun 5, 2020

Conversation

@Izorkin
Copy link
Contributor

Izorkin commented May 15, 2020

Motivation for this change

Update mariadb to 10.4.13
Update mariadb-galera to 26.4.5

cc @aanderse @flokli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Izorkin Izorkin force-pushed the Izorkin:mariadb-update branch from 78e45e5 to f23e4bd May 23, 2020
@Izorkin
Copy link
Contributor Author

Izorkin commented May 23, 2020

Added test mysql57 and mysql80 with unix auth.

@ofborg ofborg bot added the 6.topic: nixos label May 23, 2020
@Izorkin Izorkin requested a review from aanderse Jun 4, 2020
@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 4, 2020

@flokli
flokli approved these changes Jun 5, 2020
@flokli flokli merged commit 47d4cd2 into NixOS:master Jun 5, 2020
17 checks passed
17 checks passed
mariadb, mariadb-galera, mariadb-galera.passthru.tests, mariadb.passthru.tests on aarch64-linux Failure
Details
mariadb, mariadb-galera, mariadb-galera.passthru.tests, mariadb.passthru.tests on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0342862"; rev="0342862b9150aae89150f198e53e08ce777a3738"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0342862"; rev="0342862b9150aae89150f198e53e08ce777a3738"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0342862"; rev="0342862b9150aae89150f198e53e08ce777a3738"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0342862"; rev="0342862b9150aae89150f198e53e08ce777a3738"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0342862"; rev="0342862b9150aae89150f198e53e08ce777a3738"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0342862"; rev="0342862b9150aae89150f198e53e08ce777a3738"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0342862"; rev="0342862b9150aae89150f198e53e08ce777a3738"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mariadb, mariadb-galera, mariadb-galera.passthru.tests, mariadb.passthru.tests on x86_64-linux Success
Details
@flokli
Copy link
Contributor

flokli commented Jun 5, 2020

I'm a bit afraid of the test growing much larger and getting less readable - what do you think about refactoring this test to be a bit more dynamic, by passing in the specific mysql package under test as an argument, and instantiate it with all different flavours from all-tests.nix (similar to how we do with login.nix or networkd.nix)?

We could still have some flavour-specifics as conditionals, but just avoid duplicating more and more code there.

@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 5, 2020

@flokli possible the variant of simply separatory into mysql57, mysql80 and mariadb?

@flokli
Copy link
Contributor

flokli commented Jun 5, 2020

No, the goal is to have less code duplication. We don't solve this by moving this into separate files ;-)

@Izorkin Izorkin deleted the Izorkin:mariadb-update branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.