Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oniguruma: 6.9.4 -> 6.9.5_rev1 #88040

Merged
merged 1 commit into from May 28, 2020
Merged

oniguruma: 6.9.4 -> 6.9.5_rev1 #88040

merged 1 commit into from May 28, 2020

Conversation

@zowoq
Copy link
Contributor

zowoq commented May 18, 2020

https://github.com/kkos/oniguruma/blob/v6.9.5_rev1/HISTORY

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@marsam marsam merged commit 0c836fa into NixOS:master May 28, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="044857e"; rev="044857e11cef5759c21184595b405adc74af751c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="044857e"; rev="044857e11cef5759c21184595b405adc74af751c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="044857e"; rev="044857e11cef5759c21184595b405adc74af751c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="044857e"; rev="044857e11cef5759c21184595b405adc74af751c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="044857e"; rev="044857e11cef5759c21184595b405adc74af751c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="044857e"; rev="044857e11cef5759c21184595b405adc74af751c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="044857e"; rev="044857e11cef5759c21184595b405adc74af751c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
oniguruma, oniguruma.passthru.tests on aarch64-linux Success
Details
oniguruma, oniguruma.passthru.tests on x86_64-linux Success
Details
@zowoq zowoq deleted the zowoq:oniguruma branch May 28, 2020
@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented on 044857e May 28, 2020

This update broke test suite of jq on i686-linux, consequently blocking the nixos-unstable channel.

When I add valgrind and which, I get extended info:

FAIL: tests/onigtest
====================

==11064== Invalid read of size 4
==11064==    at 0x41C75D1: i_names (in /nix/store/d2i5i5pcj7xycaa2jkijjqqyw5r958qb-onig-6.9.5_rev1/lib/libonig.so)
==11064==    by 0x41ED343: onig_st_foreach (in /nix/store/d2i5i5pcj7xycaa2jkijjqqyw5r958qb-onig-6.9.5_rev1/lib/libonig.so)
==11064==    by 0x41CB247: onig_foreach_name (in /nix/store/d2i5i5pcj7xycaa2jkijjqqyw5r958qb-onig-6.9.5_rev1/lib/libonig.so)
==11064==    by 0x404B999: f_match (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x4063471: jq_next (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x40684A1: run_jq_tests (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x4068B71: jq_testsuite (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x804C8AF: main (main.c:508)
==11064==  Address 0x8 is not stack'd, malloc'd or (recently) free'd
==11064== 
==11064== 
==11064== Process terminating with default action of signal 11 (SIGSEGV)
==11064==  Access not within mapped region at address 0x8
==11064==    at 0x41C75D1: i_names (in /nix/store/d2i5i5pcj7xycaa2jkijjqqyw5r958qb-onig-6.9.5_rev1/lib/libonig.so)
==11064==    by 0x41ED343: onig_st_foreach (in /nix/store/d2i5i5pcj7xycaa2jkijjqqyw5r958qb-onig-6.9.5_rev1/lib/libonig.so)
==11064==    by 0x41CB247: onig_foreach_name (in /nix/store/d2i5i5pcj7xycaa2jkijjqqyw5r958qb-onig-6.9.5_rev1/lib/libonig.so)
==11064==    by 0x404B999: f_match (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x4063471: jq_next (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x40684A1: run_jq_tests (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x4068B71: jq_testsuite (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x804C8AF: main (main.c:508)
==11064==  If you believe this happened as a result of a stack
==11064==  overflow in your program's main thread (unlikely but
==11064==  possible), you can try to increase the size of the
==11064==  main thread stack using the --main-stacksize= flag.
==11064==  The main thread stack size used in this run was 8388608.
Testing '[match("( )*"; "g")]' at line number 2
Testing '[match("( )*"; "gn")]' at line number 6
Testing '[match("a"; "gi")]' at line number 10
Testing '[match(["(bar)"])]' at line number 14
Testing '[match("bar")]' at line number 19
Testing '[match("bār")]' at line number 24
Testing '[match(".+?\\b")]' at line number 28
Testing '[match(["foo (?<bar123>bar)? foo", "ig"])]' at line number 32
==11064== 638 (616 direct, 22 indirect) bytes in 1 blocks are definitely lost in loss record 105 of 117
==11064==    at 0x4035529: malloc (in /nix/store/gf1w01i9piicyc5qmsjaxi98afaqqb2v-valgrind-3.15.0/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==11064==    by 0x403779E: realloc (in /nix/store/gf1w01i9piicyc5qmsjaxi98afaqqb2v-valgrind-3.15.0/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==11064==    by 0x406FA9B: jv_mem_realloc (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x4060044: stack_reallocate.isra.0 (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x40601FA: frame_push (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x40642F5: jq_start (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x40683C5: run_jq_tests (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x4068B71: jq_testsuite (in /nix/store/savj9ji6nig39ah4b3hnp91hvnllav4l-jq-1.6-lib/lib/libjq.so.1.0.4)
==11064==    by 0x804C8AF: main (main.c:508)
==11064== 
Segmentation fault (core dumped)
FAIL tests/onigtest (exit status: 139)
vcunat added a commit that referenced this pull request May 29, 2020
This fixes pkgsi686Linux.jq tests, for unknown reasons.  See also:
#88040 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.