Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hobbes: 2020-03-10 -> 2020-05-19 #88205

Merged
merged 1 commit into from May 20, 2020
Merged

hobbes: 2020-03-10 -> 2020-05-19 #88205

merged 1 commit into from May 20, 2020

Conversation

kthielen
Copy link
Contributor

Motivation for this change

Moving to more recent compiler versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kthielen kthielen changed the title build latest hobbes with gcc 9 hobbes: 2020-03-10 -> 2020-05-19 May 19, 2020
@ofborg ofborg bot requested a review from thmzlt May 19, 2020 21:48
@kthielen kthielen force-pushed the hobbes/upgrade branch 2 times, most recently from 88a604e to 7fe608e Compare May 19, 2020 22:31
@bhipple
Copy link
Contributor

bhipple commented May 20, 2020

@GrahamcOfBorg build hobbes

@bhipple
Copy link
Contributor

bhipple commented May 20, 2020

Result of nixpkgs-review pr 88205 1

1 package built:
- hobbes

@bhipple bhipple merged commit 4f30177 into NixOS:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@thmzlt thmzlt Awaiting requested review from thmzlt

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kthielen @bhipple @Janik-Haag