Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake-language-server: init at 0.1.1 #89062

Merged
merged 3 commits into from May 29, 2020

Conversation

kira-bruneau
Copy link
Contributor

Motivation for this change

Fixes #80264

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/89062
6 packages built:
cmake-language-server python27Packages.pytest-datadir python37Packages.pygls python37Packages.pytest-datadir python38Packages.pygls python38Packages.pytest-datadir

@jonringer
Copy link
Contributor

jonringer commented May 28, 2020

for the python packages, they should have the installable path, so the commit subject lines should be:

python3Packages.pygls: init at ...
...

otherwise LGTM

@kira-bruneau
Copy link
Contributor Author

@jonringer Oh right I forgot about that 👍. I've force pushed the changes.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 89062 1

6 packages built:
- cmake-language-server
- python27Packages.pytest-datadir
- python37Packages.pygls
- python37Packages.pytest-datadir
- python38Packages.pygls
- python38Packages.pytest-datadir

@jonringer jonringer merged commit ec905d0 into NixOS:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: cmake-language-server
2 participants