Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/shell: added environment.shellFiles option #89943

Closed
wants to merge 7 commits into from

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Jun 9, 2020

Motivation for this change

This will allow to use standard packages to add to the init shell scripts whitout having to go lookinto said package to fing the specific file to include.However I still need #82743 to not make the module system choke on the all the attributes normal packages have.

The edit on thefuck,while still improving the shell load times,is more to check that the system is working.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pasqui23
Copy link
Contributor Author

pasqui23 commented Jun 9, 2020

Update:it turns out that you only need _modules.check=false to use packages as submodules.

@pasqui23 pasqui23 marked this pull request as ready for review June 13, 2020 21:29
@pasqui23
Copy link
Contributor Author

I've modified a few packages to support the option,to both give an example and to give packages ready to be used

@pasqui23 pasqui23 changed the title [WIP] nixos/shell: added environment.shellFiles option nixos/shell: added environment.shellFiles option Jun 17, 2020
@pasqui23
Copy link
Contributor Author

While there are many packages that still need to be upgraded to this option,I still think this is a good start

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/206

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/331

@pasqui23
Copy link
Contributor Author

Upended by #110762

@pasqui23 pasqui23 closed this Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants