New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyper: 2.1.2 -> 3.1.0-canary.4 #91153
Conversation
I'm unable to start
System details
|
@timstott I'm trying to debug this but it's working on both my NixOS and macOS environments. Are you able to run the current version of Hyper? |
@pradyuman I'm able to run the current version of Hyper on NixOS, but not macOS (it failed on a compilation step - note that I am happy to provide additional debug data on request as I am not familiar with this package. |
@timstott Just realized that I actually have Hyper installed on macOS so that what I was calling on accident there (super dumb by me, I know). I didn't look into the derivation itself too much and glossed over the fact that it's not being built from source. I just cleaned up the file a bit and decided to upgrade to 3.1.0-canary.4 which is stable according to vercel/hyper#4194. This brings with it a lot of upgrades including electron 6. Mind trying again to see if this fixes things? |
src = fetchurl { | ||
url = "https://github.com/zeit/hyper/releases/download/${version}/hyper_${version}_amd64.deb"; | ||
sha256 = "1n4qlbk7q9zkhhg72mdks95g15xgyrc6ixf882ghvrqghd4zxplm"; | ||
url = "https://github.com/vercel/hyper/releases/download/v${version}/hyper_${version}_amd64.deb"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Note to self: Vercel (formerly ZEIT)
@pradyuman I'm still unable to start Expand output
[nix-shell:~/.cache/nixpkgs-review/pr-91153-6]$ hyper
Error: Cannot find module 'native-reg'
Require stack:
- /nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/utils/cli-install.js
- /nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/index.js
-
at Module._resolveFilename (internal/modules/cjs/loader.js:717:15)
at Function../lib/common/reset-search-paths.ts.Module._resolveFilename (electron/js2c/browser_init.js:7646:16)
at Module._load (internal/modules/cjs/loader.js:622:27)
at Module._load (electron/js2c/asar.js:717:26)
at Function.Module._load (electron/js2c/asar.js:717:26)
at Function._load (/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/plugins.js:82:37)
at Module.require (internal/modules/cjs/loader.js:775:19)
at require (internal/modules/cjs/helpers.js:68:18)
at Object.<anonymous> (/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/utils/cli-install.js:13:20)
at Module._compile (internal/modules/cjs/loader.js:880:30) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/utils/cli-install.js',
'/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/index.js',
undefined
]
}
(electron) 'getName function' is deprecated and will be removed. Please use 'name property' instead.
innerError Error: Cannot find module '../build/Debug/pty.node'
Require stack:
- /nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/unixTerminal.js
- /nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/index.js
- /nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/session.js
- /nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/ui/window.js
- /nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/index.js
-
at Module._resolveFilename (internal/modules/cjs/loader.js:717:15)
at Function../lib/common/reset-search-paths.ts.Module._resolveFilename (electron/js2c/browser_init.js:7646:16)
at Module._load (internal/modules/cjs/loader.js:622:27)
at Module._load (electron/js2c/asar.js:717:26)
at Function.Module._load (electron/js2c/asar.js:717:26)
at Function._load (/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/plugins.js:82:37)
at Module.require (internal/modules/cjs/loader.js:775:19)
at require (internal/modules/cjs/helpers.js:68:18)
at Object.<anonymous> (/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/unixTerminal.js:30:15)
at Module._compile (internal/modules/cjs/loader.js:880:30) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/unixTerminal.js',
'/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/index.js',
'/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/session.js',
'/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/ui/window.js',
'/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/index.js',
undefined
]
}
A JavaScript error occurred in the main process
Uncaught Exception:
Error: `node-pty` failed to load. Typically this means that it was built incorrectly. Please check the `readme.md` to more info.
at createNodePtyError (/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/session.js:19:34)
at Object.<anonymous> (/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/session.js:25:11)
at Module._compile (internal/modules/cjs/loader.js:880:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
at Module.load (internal/modules/cjs/loader.js:735:32)
at Module._load (internal/modules/cjs/loader.js:648:12)
at Module._load (electron/js2c/asar.js:717:26)
at Function.Module._load (electron/js2c/asar.js:717:26)
at Function._load (/nix/store/ch1b5ygxrrc749j07a9rrf5rwvngbhp4-hyper-3.1.0-canary.4/opt/Hyper/resources/app.asar/plugins.js:82:37)
at Module.require (internal/modules/cjs/loader.js:775:19)
Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank"
^C |
@timstott Ah, that's unfortunate. It looks like the node-pty error is a known issue: vercel/hyper#3321. The native-reg error is apparently harmless: vercel/hyper#4320 I'm unable to reproduce this issue on my machine but I'll do some research to see if there's any additional information I can find. In the meantime, I'll link this PR in the GitHub issue and see if the hyper team has an idea of how to debug this. Thanks for your help! |
Motivation for this change
Upgrade to the latest Hyper.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)