Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emu2: init at unstable-2020-06-04 #91193

Merged
merged 1 commit into from Jul 3, 2020
Merged

emu2: init at unstable-2020-06-04 #91193

merged 1 commit into from Jul 3, 2020

Conversation

@dramaturg
Copy link
Contributor

dramaturg commented Jun 20, 2020

Motivation for this change

This adds the emu2 DOS emulator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

nixos-discourse commented Jul 2, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/210

Copy link
Member

danieldk left a comment

Two small suggested changes.

pkgs/misc/emulators/emu2/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/emu2/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/emu2/default.nix Show resolved Hide resolved
@dramaturg dramaturg force-pushed the dramaturg:emu2 branch from 788cdd8 to 0bad8bb Jul 3, 2020
Copy link
Member

danieldk left a comment

LGTM.

Result of nixpkgs-review pr 91193 1

1 package built:
- emu2

Binary runs as expected.

For a future update, you may want to check if Darwin works as well. It seems that upstream made some changes to accommodate Darwin:

dmsc/emu2#4

@danieldk danieldk merged commit e932a72 into NixOS:master Jul 3, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
emu2, emu2.passthru.tests on aarch64-linux Success
Details
emu2, emu2.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0bad8bb"; rev="0bad8bb45b9521079423f7b183d45c950193479e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0bad8bb"; rev="0bad8bb45b9521079423f7b183d45c950193479e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0bad8bb"; rev="0bad8bb45b9521079423f7b183d45c950193479e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0bad8bb"; rev="0bad8bb45b9521079423f7b183d45c950193479e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0bad8bb"; rev="0bad8bb45b9521079423f7b183d45c950193479e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0bad8bb"; rev="0bad8bb45b9521079423f7b183d45c950193479e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0bad8bb"; rev="0bad8bb45b9521079423f7b183d45c950193479e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.