Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-packages updates scipy and scikitlearn #9146

Closed
wants to merge 2 commits into from
Closed

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Aug 6, 2015

Built and installed locally. Tested with Python 3.4.

@FRidh
Copy link
Member Author

FRidh commented Aug 7, 2015

The build failed due to running out of memory

Which isn't untypical for scipy

Also tested with Python 2.7, as well as pypy which cannot build since numpy cannot build, as expected.

@bjornfor
Copy link
Contributor

It seems python*Packages.scikitlearn fail with scipy 0.16.0. They fail during test phase.

@bjornfor
Copy link
Contributor

cc @offlinehacker, who added scikit-learn to nixpkgs.

@FRidh
Copy link
Member Author

FRidh commented Aug 10, 2015

There are indeed some tests in scikit-learn 0.16.0 that fail with scipy 0.16.
scikit-learn/scikit-learn#5045

scikit-learn 0.16.1 is the latest release, but that version has the same issues.

@FRidh
Copy link
Member Author

FRidh commented Aug 15, 2015

In c3b7549 I disabled scikit-learn tests.

Some tests in scikit-learn 0.16.1 fail with the new scipy 0.16 package.
This is known upstream and should be fixed in the next release.
scikit-learn/scikit-learn#5045

This commit disables the tests until the next scikit-learn release.

Some tests in scikit-learn 0.16.1 fail with the new scipy 0.16 package.
This is known upstream and should be fixed in the next release.
scikit-learn/scikit-learn#5045

This commit disables the tests until the next scikit-learn release.
@FRidh FRidh changed the title python-packages scipy: 0.15.1 -> 0.16.0 python-packages updates Oct 20, 2015
@FRidh FRidh changed the title python-packages updates python-packages updates scipy and scikitlearn Oct 20, 2015
@FRidh
Copy link
Member Author

FRidh commented Oct 20, 2015

This PR now updates both scipy and scikit-learn. The scipy update caused some scikit-learn tests to fail. The current beta of scikit-learn upcoming new version fixes these issues. Therefore, scikit-learn is now updated also to that beta.

I've built locally with nox review wip.

@FRidh
Copy link
Member Author

FRidh commented Oct 20, 2015

Travis failed due to running out of memory.

@FRidh
Copy link
Member Author

FRidh commented Oct 22, 2015

Merged in #10255

@FRidh FRidh closed this Oct 22, 2015
@FRidh FRidh deleted the scipy branch October 22, 2015 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants