Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslinux: make reproducible #91672

Merged
merged 1 commit into from Jul 2, 2020
Merged

Conversation

@ajs124
Copy link
Member

ajs124 commented Jun 27, 2020

Motivation for this change

I saw it on https://r13y.com/ and I changed stuff in syslinux recently.
This time I tested if it still builds on i686.

The reason why I needed to import the patch is that it was missing memdisk/Makefile and it tried to use git to determine a date.

Both patches are fetched and HEXDATE is set through makeFlags.

I also changed the url of the patch I introduced in #85094 to one that should be more stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @grahamc @samueldr

@jtojnar
Copy link
Contributor

jtojnar commented Jun 27, 2020

The reason why I needed to import the patch is that it was missing memdisk/Makefile and it tried to use git to determine a date.

Could we pass HEXDATE=0x00000000 to makeFlags instead?

@ajs124 ajs124 force-pushed the helsinki-systems:reprod/syslinux branch from e15645d to 1c8d4f6 Jun 27, 2020
@ajs124
Copy link
Member Author

ajs124 commented Jun 27, 2020

That seems to works as well, yes. We could probably go back to the arch patch with that, if we wanted to. Do we want to?

@jtojnar
Copy link
Contributor

jtojnar commented Jun 27, 2020

Yeah, I think that would be nicer.

@ajs124 ajs124 force-pushed the helsinki-systems:reprod/syslinux branch from 1c8d4f6 to 64cbeaf Jun 27, 2020
@ajs124
Copy link
Member Author

ajs124 commented Jun 29, 2020

This supersedes/includes #82839.

@bjornfor bjornfor merged commit 5756862 into NixOS:master Jul 2, 2020
16 checks passed
16 checks passed
syslinux, syslinux.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64cbeaf"; rev="64cbeaf4255aabf9f58eed3d5545621c17c3cedb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64cbeaf"; rev="64cbeaf4255aabf9f58eed3d5545621c17c3cedb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64cbeaf"; rev="64cbeaf4255aabf9f58eed3d5545621c17c3cedb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64cbeaf"; rev="64cbeaf4255aabf9f58eed3d5545621c17c3cedb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64cbeaf"; rev="64cbeaf4255aabf9f58eed3d5545621c17c3cedb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64cbeaf"; rev="64cbeaf4255aabf9f58eed3d5545621c17c3cedb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="64cbeaf"; rev="64cbeaf4255aabf9f58eed3d5545621c17c3cedb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
syslinux, syslinux.passthru.tests on x86_64-linux Success
Details
@bjornfor bjornfor mentioned this pull request Jul 2, 2020
6 of 10 tasks complete
@ajs124 ajs124 deleted the helsinki-systems:reprod/syslinux branch Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.