Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsrt: init at 1.4.1 #91696

Closed
wants to merge 2 commits into from
Closed

libsrt: init at 1.4.1 #91696

wants to merge 2 commits into from

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Jun 27, 2020

Motivation for this change

I'd like to compile ffmpeg with Secure Reliable Transport (SRT) support (https://github.com/Haivision/srt, https://www.srtalliance.org/).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb lukegb mentioned this pull request Jun 27, 2020
Merged
10 tasks
@nh2
Copy link
Contributor

nh2 commented Jun 27, 2020

I already packaged srt January 2019: #54380

It's here: https://github.com/NixOS/nixpkgs/blob/a3013da6a272780adb46aadf4bf192136301c99c/pkgs/development/libraries/srt/default.nix

nh2
nh2 requested changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add yourself to srt's maintainers though!

@lukegb
Copy link
Contributor Author

lukegb commented Jun 27, 2020

facepalm good catch

@lukegb lukegb closed this Jun 27, 2020
@lukegb lukegb deleted the init-libsrt branch December 5, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @nh2