New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.webargs: init at 6.1.0 #91703
Conversation
@jonringer thanks for all the suggestions! I applied them all and rebased the branch. |
I marked this as stale due to inactivity. → More info |
@cript0nauta still interested in this? sorry it got backburnered |
description = | ||
"Declarative parsing and validation of HTTP request objects, with built-in support for popular web frameworks"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = | |
"Declarative parsing and validation of HTTP request objects, with built-in support for popular web frameworks"; | |
description = "Declarative parsing and validation of HTTP request objects, with built-in support for popular web frameworks"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. BTW, I used nixfmt to format this file, that's why it had an extra linebreak.
|
||
propagatedBuildInputs = [ marshmallow ]; | ||
checkInputs = [ | ||
pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest | |
pytestCheckHook |
checkPhase = '' | ||
rm tests/test_webapp2parser.py # webapp2 doesn't support python 3 | ||
pytest | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkPhase = '' | |
rm tests/test_webapp2parser.py # webapp2 doesn't support python 3 | |
pytest | |
''; | |
preCheck = '' | |
rm tests/test_webapp2parser.py # webapp2 doesn't support python 3 | |
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was already removed in webargs 8.0.0, so there is no need to remove it from the Nix expressoin.
@@ -0,0 +1,42 @@ | |||
{ buildPythonPackage, fetchPypi, lib, isPy27, marshmallow, pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ buildPythonPackage, fetchPypi, lib, isPy27, marshmallow, pytest | |
{ buildPythonPackage, fetchPypi, lib, isPy27, marshmallow, pytestCheckHook |
}; | ||
|
||
checkPhase = '' | ||
invoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use pytestCheckHook instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
description = | ||
"Provides integration of WebTest with aiohttp.web applications"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = | |
"Provides integration of WebTest with aiohttp.web applications"; | |
description = "Provides integration of WebTest with aiohttp.web applications"; |
@@ -21,7 +19,5 @@ buildPythonPackage rec { | |||
sha256 = "35ee2fb188f0bd9fc1cf9ac35e45fd394bd1c153cee430745a465ea435514bd5"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding yourself as a maintainer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
dbb32fc
to
a57a292
Compare
Rebased, upgraded to webargs 8 and fixed suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add pythonImportsChecks.
Done |
I forgot to mention that the last time but please squash the commits into one per package. |
Sure, done! |
Motivation for this change
I added the webargs and webtest-aiohttp Python packages. Also, removed some unused dependencies from marshmallow (otherwise the webargs test would fail).
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)