Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.angstrom 0.14.1 and update of all affected packages (encore, git) #91865

Closed
wants to merge 5 commits into from

Conversation

@sternenseemann
Copy link
Member

sternenseemann commented Jun 30, 2020

Motivation for this change

angstrom 0.14 (now bugfixed 0.14.1) broke some libraries due to an API change, in nixpkgs encore and git (and indirectly the irmin libraries). Since encore 0.5 and git 2.1.3 have been released, we can go to angstrom 0.14.1 in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

If this is merged, #90630 can be closed

@sternenseemann sternenseemann requested a review from vbgl Jun 30, 2020
@sternenseemann
Copy link
Member Author

sternenseemann commented Jun 30, 2020

Probably should check if the test skipping for git and git-unix also works on darwin. It breaks on aarch64, I guess it's simpler to disable the tests there than to patch the whole test suite.

@sternenseemann sternenseemann force-pushed the sternenseemann:angstrom-0.14.1 branch from 5b6c272 to b02b512 Jun 30, 2020
@sternenseemann
Copy link
Member Author

sternenseemann commented Jun 30, 2020

@GrahamcOfBorg build ocamlPackages.angstrom-lwt ocamlPackages.angstrom-unix ocamlPackages.angstrom-async ocamlPackages.irmin-unix ocaml-ng.ocamlPackages_4_06.email_message

@vbgl
Copy link
Contributor

vbgl commented Jul 1, 2020

@GrahamcOfBorg build ocamlPackages.irmin-unix

@vbgl
Copy link
Contributor

vbgl commented Jul 1, 2020

Merged bigarray-overlap as fce108e

@vbgl
Copy link
Contributor

vbgl commented Jul 1, 2020

Merged into master as 2c616aa

@vbgl vbgl closed this Jul 1, 2020
@sternenseemann sternenseemann deleted the sternenseemann:angstrom-0.14.1 branch Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.