Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libiio: 0.20 -> 0.21 #92047

Merged
merged 1 commit into from Jul 8, 2020
Merged

libiio: 0.20 -> 0.21 #92047

merged 1 commit into from Jul 8, 2020

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented Jul 2, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/analogdevicesinc/libiio/releases.

meta.description for libiio is: "API for interfacing with the Linux Industrial I/O Subsystem"

meta.homepage for libiio is: "https://github.com/analogdevicesinc/libiio"

meta.changelog for libiio is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
18 total rebuild path(s)

6 package rebuild(s)

6 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
libiio
python27Packages.libiio
python37Packages.libiio
python38Packages.libiio
sdrangel
urh
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/zw9l4qiwx43y2zywyhbbl9m61xm9xqwh-libiio-0.21 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libiio https://github.com/r-ryantm/nixpkgs/archive/17b9ea7bde950ac0944d0eaaa4acf0766290e4f0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/zw9l4qiwx43y2zywyhbbl9m61xm9xqwh-libiio-0.21
ls -la /nix/store/zw9l4qiwx43y2zywyhbbl9m61xm9xqwh-libiio-0.21/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

6 packages built:
- libiio
- python27Packages.libiio
- python37Packages.libiio
- python38Packages.libiio
- sdrangel
- urh

Maintainer pings

cc @thoughtpolice for testing.

@jtojnar
jtojnar approved these changes Jul 6, 2020
Copy link
Contributor

jtojnar left a comment

* Format with nixpkgs-format.
* Reorder the attribute to be more in line with convention.
* Use simpler git ref.
* Hardcode paths within bindings using patch (the replaced value actually changed in this version and without this clean-up, it would have gone unnoticed.)
* Let the build script install the python bindings instead of doing it manually (required the same hardcoding as above in the setup.py.)
* Use cmakeFlags attribute with placeholder instead of doing that in preConfigure.
* Move udev rules to lib since etc is meant for admins.
* License is actually lgpl2.1+.
@jtojnar jtojnar force-pushed the r-ryantm:auto-update/libiio branch from 17b9ea7 to 0b0b743 Jul 6, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 6, 2020

Actually, there was a code change our substitution silently fail. I discovered it during clean-ups so I converted the replacement to a patch.

I also noticed that pkg-config file contains incorrect values so I opened a PR upstream fixing that: analogdevicesinc/libiio#563

@jtojnar jtojnar merged commit 31ff58e into NixOS:master Jul 8, 2020
17 checks passed
17 checks passed
libiio, libiio.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b0b743"; rev="0b0b74367f15cf7a0f17b4ee99cc5668c2499b74"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b0b743"; rev="0b0b74367f15cf7a0f17b4ee99cc5668c2499b74"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b0b743"; rev="0b0b74367f15cf7a0f17b4ee99cc5668c2499b74"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b0b743"; rev="0b0b74367f15cf7a0f17b4ee99cc5668c2499b74"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b0b743"; rev="0b0b74367f15cf7a0f17b4ee99cc5668c2499b74"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b0b743"; rev="0b0b74367f15cf7a0f17b4ee99cc5668c2499b74"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b0b743"; rev="0b0b74367f15cf7a0f17b4ee99cc5668c2499b74"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libiio, libiio.passthru.tests on aarch64-linux Success
Details
libiio, libiio.passthru.tests on x86_64-linux Success
Details
@jtojnar jtojnar added this to Done in CMake breakage Jul 8, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/libiio branch Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.