Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insomnia-designer: init at 2020.2.2 #92093

Open
wants to merge 1 commit into
base: master
from

Conversation

@Pablo1107
Copy link
Contributor

Pablo1107 commented Jul 2, 2020

Motivation for this change

Add insomnia-designer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@puzzlewolf
Copy link
Contributor

puzzlewolf commented Jul 5, 2020

Hey, any particular reason this is built from a .deb package and not from source?


src = fetchurl {
url =
"https://github.com/Kong/insomnia/releases/download/designer@${version}/Insomnia.Designer-${version}.deb";

This comment has been minimized.

@Sohalt

Sohalt Jul 5, 2020 Contributor

Is there a reason why you are using the debian package instead of building from source?

This comment has been minimized.

@Pablo1107

Pablo1107 Jul 7, 2020 Author Contributor

I took the same approach as the currently available insomnia. I imagine is feasible to build it from source but I didn't try it and this worked well enough for me.

@Pablo1107
Copy link
Contributor Author

Pablo1107 commented Jul 7, 2020

Hey, any particular reason this is built from a .deb package and not from source?

As I answer to @Sohalt : I took the same approach as the currently available insomnia. I imagine is feasible to build it from source but I didn't try it and this worked well enough for me.

@Pablo1107
Copy link
Contributor Author

Pablo1107 commented Jul 19, 2020

@Sohalt @puzzlewolf will building from source be a requirement for this package to be merged?

I wonder how insomnia got merged if this is the case.

Copy link
Contributor

puzzlewolf left a comment

No, building from source is not required, but it's usually preferred.

I don't have much experience with this kind of package, sry. But the the derivation is very similar to insomnia, and that got merged. So I guess this is ok :)

Result of nixpkgs-review pr 92093 1

1 package built:
- insomnia-designer
pkgs/development/web/insomnia/designer.nix Outdated Show resolved Hide resolved
pkgs/development/web/insomnia/designer.nix Outdated Show resolved Hide resolved
Pablo Andres Dealbera
@Pablo1107 Pablo1107 force-pushed the Pablo1107:insomnia-designer-2020.2.2 branch from 004b19d to 9a1c5b1 Jul 20, 2020
@Pablo1107
Copy link
Contributor Author

Pablo1107 commented Jul 20, 2020

@puzzlewolf I added myself as maintainer and fixed metadata.

Copy link
Contributor

puzzlewolf left a comment

looks good to me now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.