Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insomnia-designer: init at 2020.4.1 #92093

Closed
wants to merge 1 commit into from
Closed

insomnia-designer: init at 2020.4.1 #92093

wants to merge 1 commit into from

Conversation

Pablo1107
Copy link
Contributor

@Pablo1107 Pablo1107 commented Jul 2, 2020 •
edited

Motivation for this change

Add insomnia-designer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from markus1189 and babariviere July 2, 2020 20:53
@puzzlewolf
Copy link
Contributor

Hey, any particular reason this is built from a .deb package and not from source?

@Pablo1107
Copy link
Contributor Author

Hey, any particular reason this is built from a .deb package and not from source?

As I answer to @Sohalt : I took the same approach as the currently available insomnia. I imagine is feasible to build it from source but I didn't try it and this worked well enough for me.

@Pablo1107
Copy link
Contributor Author

@Sohalt @puzzlewolf will building from source be a requirement for this package to be merged?

I wonder how insomnia got merged if this is the case.

puzzlewolf
puzzlewolf suggested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, building from source is not required, but it's usually preferred.

I don't have much experience with this kind of package, sry. But the the derivation is very similar to insomnia, and that got merged. So I guess this is ok :)

Result of nixpkgs-review pr 92093 1

1 package built:
- insomnia-designer

pkgs/development/web/insomnia/designer.nix Show resolved Hide resolved
pkgs/development/web/insomnia/designer.nix Show resolved Hide resolved
@Pablo1107
Copy link
Contributor Author

@puzzlewolf I added myself as maintainer and fixed metadata.

puzzlewolf
puzzlewolf approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now 👍

@Pablo1107 Pablo1107 changed the title insomnia-designer: init at 2020.2.2 insomnia-designer: init at 2020.4.1 Oct 29, 2020
@Pablo1107
Copy link
Contributor Author

Update to 2020.4.1. I've been successfully running this package since several months.

SuperSandro2000
SuperSandro2000 reviewed Nov 26, 2020
View reviewed changes
pkgs/development/web/insomnia/designer.nix
Comment on lines +22 to +23
url =
"https://github.com/Kong/insomnia/releases/download/designer@${version}/Insomnia.Designer-${version}.deb";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url =
"https://github.com/Kong/insomnia/releases/download/designer@${version}/Insomnia.Designer-${version}.deb";
url = "https://github.com/Kong/insomnia/releases/download/designer@${version}/Insomnia.Designer-${version}.deb";

pkgs/development/web/insomnia/designer.nix
Comment on lines +27 to +28
nativeBuildInputs =
[ autoPatchelfHook dpkg makeWrapper gobject-introspection wrapGAppsHook ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs =
[ autoPatchelfHook dpkg makeWrapper gobject-introspection wrapGAppsHook ];
nativeBuildInputs = [ autoPatchelfHook dpkg makeWrapper gobject-introspection wrapGAppsHook ];

pkgs/development/web/insomnia/designer.nix
Comment on lines +90 to +91
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
};

pkgs/development/web/insomnia/designer.nix
description = "The most intuitive cross-platform REST API Client";
license = licenses.mit;
platforms = [ "x86_64-linux" ];
maintainers = with maintainers; [ markus1189 babariviere ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself as maintainer and not other people.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 92093 run on x86_64-linux 1

1 package built:
  • insomnia-designer

@Ekleog
Copy link
Member

Ekleog commented Jan 20, 2021

@Pablo1107 Would you be willing to implement @SuperSandro2000's suggestions? I have not reviewed myself yet, but this discussion looks to me like when you implement them it'll become possible to land this PR, and hopefully the suggestions should be simple to implement :) (I'd just go ahead, click “Commit suggestion” and land myself right now, but I don't want to add you as a maintainer if you don't actually want to be :/)

@Pablo1107
Copy link
Contributor Author

@Ekleog yes, I'll see to push those changes so you can merge it.

@stale
Copy link

stale bot commented Jul 22, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 22, 2021
@Pablo1107 Pablo1107 closed this Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sohalt Sohalt Sohalt left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@babariviere babariviere babariviere approved these changes

@puzzlewolf puzzlewolf puzzlewolf approved these changes

@markus1189 markus1189 Awaiting requested review from markus1189

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Pablo1107 @puzzlewolf @SuperSandro2000 @Ekleog @Sohalt @babariviere