Audio updates #9273
Audio updates #9273
Conversation
| @@ -42,7 +38,7 @@ stdenv.mkDerivation rec { | |||
| ]; | |||
|
|
|||
| patchPhase = '' | |||
| printf '#include "libs/ardour/ardour/revision.h"\nnamespace ARDOUR { const char* revision = \"${revision}\"; }\n' > libs/ardour/revision.cc | |||
| printf '#include "libs/ardour/ardour/revision.h"\nnamespace ARDOUR { const char* revision = \"${tag}-${builtins.substring 0 8 src.rev}\"; }\n' > libs/ardour/revision.cc | |||
There was a problem hiding this comment.
This is fixed now with a modificaiton to fetchFromGitHub
|
Please rename commit's name following our guide in |
|
/cc maintainer @cillianderoiste. |
|
Travis check is ok now, build killed because of memory constraints |
|
Please notice my first comment :) |
This means it is more consistent with fetchgit which returns rev.
|
@jagajaga fixed :) |
|
Thanks @joelmo, if you want to rkrlv2 in a separate PR I'd be happy to merge that, but I'd like a second opinion on the change to fetchFromGitHub. I guess it will trigger a lot of rebuilds and maybe it's overkill ... or, on the other hand, maybe it's a clever addition. |
|
No, the |
|
Thanks, I'll build it here tomorrow and check (since Travis is running out of memory). |
No description provided.