nodePackages.get-graphql-schema: init at 2.1.2

[Zimmi48]

Motivation for this change

get-graphql-schema is a simple command-line tool to fetch a GraphQL schema. graphql-cli used to provide this feature too but since version 4.0.0, it doesn't anymore without several plugins.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[ludovicc]

Prisma has handed over development of their GraphQL tools to The Guild. Now to fetch a GraphQL schema, a good choice is to use https://graphql-inspector.com/. I'd rather see this tool added to Nix.

[Zimmi48]

I just tried preparing a branch adding graphql-inspector, installing it and running the graphql-inspector introspect command, but unfortunately, I get an error:

internal/modules/cjs/loader.js:969
  throw err;
  ^

Error: Cannot find module 'graphql'

I understand the maintenance concern, but given how simple the get-graphql-schema command is, it should work out just fine even without being updated. OTOH, graphql-inspector is a much bigger beast and while it would do the job as well if it were working, I'd rather have get-graphql-schema in than nothing at all.

[ludovicc]

Reviewed points

• module path fits the guidelines
• module tests succeed on Darwin (build but not tests)
• options have appropriate types
• options have default
• options have example
• options have descriptions
• No unneeded package is added to environment.systemPackages
• meta.maintainers is set
• module documentation is declared in meta.doc

Possible improvements

@Zimmi48 Please add yourself as maintainer for this package.

Comments

[Zimmi48]

Thanks for the review. Unfortunately, given the automatic generation for these packages, I don't think there's anyway to list maintainers for them (contrary to hand-defined derivations). I'll regenerate the PR since it is in conflict with master now (unfortunately, due to the nature of this generation mechanism, these PRs quickly stale if they are not merged).

[Zimmi48]

Rebased.

[Zimmi48]

This PR got stale again for lack of someone available to merge it. I'll rebase again only once someone tells me they will merge it afterwards.

[infinisil]

@Zimmi48 Will merge it if you rebase it, ping me when done :)

[Zimmi48]

Thanks @infinisil! Done.