Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aerc: fix GOFLAGS #93455

Merged
merged 1 commit into from Jul 20, 2020
Merged

aerc: fix GOFLAGS #93455

merged 1 commit into from Jul 20, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jul 19, 2020

Motivation for this change

buildGoModule doesn't pass additional GOFLAGS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member

@zowoq wouldn't it make more sense to add support for it in buildGoModule?

@zowoq
Copy link
Contributor Author

zowoq commented Jul 20, 2020

This is the only package that uses GOFLAGS like this. Supporting {build,install,make}Flags, etc when we override the default phases is something I've been thinking about but that's another PR.

@kalbasit
Copy link
Member

Fair enough!

@kalbasit kalbasit merged commit 902987d into NixOS:master Jul 20, 2020
@zowoq zowoq deleted the aerc branch July 20, 2020 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants