Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package mockbob #93563

Closed
wants to merge 1 commit into from
Closed

Add package mockbob #93563

wants to merge 1 commit into from

Conversation

fionera
Copy link
Member

@fionera fionera commented Jul 20, 2020

Motivation for this change

Adding Mockbob as Package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to conform to the guidelines:

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

I don't say this quickly, but I am also doubting whether it is useful to have this in nixpkgs.

pkgs/applications/misc/mockbob/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mockbob/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mockbob/default.nix Outdated Show resolved Hide resolved
@fionera
Copy link
Member Author

fionera commented Jul 21, 2020

Thanks for the Review. I just applied your requested changes. Regarding the purpose I first wanted to use nixos.rPackages.spongebob, but apparently it doesnt compile to a binary you can use from cli

@danieldk danieldk self-requested a review July 21, 2020 09:23
@danieldk
Copy link
Contributor

Thanks for making the changes. Let's see if someone finds this merge-worthy ;).

@infinisil
Copy link
Member

Coming back to this, I don't think we should include this in nixpkgs because:

  • It doesn't seem to be popular at all (no stars on github at least)
  • It's not very useful, it's really only a gimmick without any real use case. In comparison, e.g. cmatrix is at least nice to look at.
  • It's a rust package, which makes it a bit more expensive to build, combined with above points, I don't think it's worth the hydra resources

I'll close this because of this, but I think NUR would be a pretty good place for this instead

@infinisil infinisil closed this Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants