Apache service module: allow compression

[wmertens]

Adds enableCompression flag and sets up mod_deflate.

[wmertens]

No complaints and low-impact and checks pass so merging.

[edolstra]

I'm 👎 on this because it's just too site-specific. It's a bunch of highly browser- and file type specific rules. That kind of site-specific policy really shouldn't be in a generic NixOS module.

[wmertens]

Well, OTOH setting up compression is not trivial and this set of rules
seemed nice enough for general use.

It is optional, and you can always define your own rules.

Is there any rule in particular that you don't like or that should be
configurable?

On Tue, Aug 25, 2015, 10:33 Eelco Dolstra notifications@github.com wrote:

I'm [image: 👎] on this because it's just too site-specific. It's a
bunch of highly browser- and file type specific rules. That kind of
site-specific policy really shouldn't be in a generic NixOS module.

—
Reply to this email directly or view it on GitHub
#9407 (comment).

Wout.
(typed on mobile, excuse terseness)

[qknight]

@edolstra
i think that this global flag is a good thing. but anyway, if you want it to be vhost specific, we can't use Nix to configure it as there is no vhost abstraction yet, correct?

deflate per vhost config

this is how i enabled deflate:

    extraModules = [
      { name = "php5"; path = "${pkgs.php}/modules/libphp5.so"; }
      { name = "deflate"; path = "${pkgs.apacheHttpd}/modules/mod_deflate.so"; }
    ];

and

    virtualHosts =
    [
      {
        hostName = "example.com";
        enableSSL = false;
        extraConfig = ''
          ... many lines ...
          SetOutputFilter DEFLATE
        '';
       ...

in the extraConfig of the vhost.