New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libvirt: add hyperv driver #94599
libvirt: add hyperv driver #94599
Conversation
@@ -8,6 +8,7 @@ | |||
, enableXen ? false, xen ? null | |||
, enableIscsi ? false, openiscsi | |||
, enableCeph ? false, ceph | |||
, enableHyperv ? true, openwsman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please disable this by default because this will be used by a very tiny amount of people.
I was not able to use this to connect to a Hyper-V 2016 server. This may or may not be related to how this bug report says the hyper-v module is unmaintained: https://bugzilla.redhat.com/show_bug.cgi?id=1253265 |
@@ -8,6 +8,7 @@ | |||
, enableXen ? false, xen ? null | |||
, enableIscsi ? false, openiscsi | |||
, enableCeph ? false, ceph | |||
, enableHyperv ? true, openwsman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please disable this by default because this will be used by a very tiny amount of people.
9657fe2
to
f8b88de
Compare
It might be worth verifying that libvirt's hyperv driver actually works before merging. I tried to do this (with a Windows 10 guest running Hyper-V), but I was unable to successfully enable Hyper-V on the guest. (It got stuck in automatic repair) |
Motivation for this change
To add Hyper-V support to libvirt
Things done
It builds, and
virsh --connect hyperv://host/
no longer complains, but I haven't tested connecting to an actual Hyper-V server yet.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)