Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt: add hyperv driver #94599

Closed
wants to merge 1 commit into from
Closed

Conversation

jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Aug 3, 2020

Motivation for this change

To add Hyper-V support to libvirt

Things done

It builds, and virsh --connect hyperv://host/ no longer complains, but I haven't tested connecting to an actual Hyper-V server yet.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • Increase in closure size: 1.7M
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -8,6 +8,7 @@
, enableXen ? false, xen ? null
, enableIscsi ? false, openiscsi
, enableCeph ? false, ceph
, enableHyperv ? true, openwsman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems wrong that HyperV is enabled by default when the rest of the drivers are not. Personally, I'd rather have the default be they are all enabled and then if someone needs a smaller size, they would disable them. However, I don't know much about this package.

cc @volth @fpletz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disable this by default because this will be used by a very tiny amount of people.

@ryantm
Copy link
Member

ryantm commented Aug 12, 2020

I was not able to use this to connect to a Hyper-V 2016 server. This may or may not be related to how this bug report says the hyper-v module is unmaintained: https://bugzilla.redhat.com/show_bug.cgi?id=1253265

@@ -8,6 +8,7 @@
, enableXen ? false, xen ? null
, enableIscsi ? false, openiscsi
, enableCeph ? false, ceph
, enableHyperv ? true, openwsman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disable this by default because this will be used by a very tiny amount of people.

@jakobrs
Copy link
Contributor Author

jakobrs commented Dec 29, 2020

It might be worth verifying that libvirt's hyperv driver actually works before merging. I tried to do this (with a Windows 10 guest running Hyper-V), but I was unable to successfully enable Hyper-V on the guest. (It got stuck in automatic repair)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants