tilt: 0.11.3 -> 0.17.0, move to buildGoModule

[w4]

Motivation for this change

Application version bump with move to their new repo and little changes to get the build working again on latest updates.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[timstott]

Result of nixpkgs-review pr 94827 1

1 package failed to build:

- tilt

builder for '/nix/store/pcfclqyl3nkg8whyza25vfrdhbhrn8wj-tilt-0.17.0-go-modules.drv' failed with 
exit code 10; last 7 log lines:
  unpacking sources
  unpacking source archive /nix/store/lx772bf5cd1saqkn90nz7dnr2iqpzkx1-source
  source root is source
  patching sources
  configuring
  building
  vendor folder exists, please set 'vendorSha256=null;' or 'deleteVendor=true;' in your expression
cannot build derivation '/nix/store/is6zizif0xsq8nklsqgiqdfvm2c6j14y-tilt-0.17.0.drv': 1 dependencies couldn't be built

[timstott]

Perhaps add deleteVendor=true as per comment 🤔

This will make buildGoModule fetch dependencies inside go.mod

[w4]

Was hoping this would work fine on other machines! It seems deleteVendor is only needed when building the first time after moving from buildGoPackage. It's not the most ergonomic since it pulls the dependencies every build, hopefully the cache speeds this up though.

nixpkgs-review pr 94827 seems to work for me after adding deleteVendor = true, how's it looking on your machine?

[timstott]

It builds and runs fine now 👌

[zowoq]

This seems to build without deleteVendor using just vendorSha256 = null?

[timstott]

@zowoq, either will work, the difference is where dependencies are sourced from. When vendorSha256 = null the vendor folder supplied with the source is used, as opposed to deletedVendor = true where dependencies will be fetched via go.mod.

[zowoq]

deleteVendor should only be used if the deps are incomplete/broken.

[timstott]

Ah, I wasn't aware, there's no indication in the docs that it should be used as such source.

However tilt's Makefile makes use of the vendored dependencies, so we should align (I should have checked that to start with).

[w4]

Makes sense, thanks for clearing that up @zowoq, just pushed the change.

[timstott]

Tested on NixOS ✔️

Thank you for your contribution 🎉

[zowoq]

Please remove deleteVendor and use vendorSha256 = null

[zowoq]

Checked locally on darwin. aarch64 failure is a CI issue, it was building previously.