Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

androidenv: fix convert files not quoting urls #95804

Merged
merged 1 commit into from Aug 19, 2020

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Aug 19, 2020

Motivation for this change

When running the ./generate.sh script, it would not quote the URLs for src.
This is fixed here, as it is a requirement.
Seems like the previous generated files have been manually tampered with, outside of the generate script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eyJhb eyJhb mentioned this pull request Aug 19, 2020
10 tasks
@infinisil infinisil merged commit 5cddce8 into NixOS:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants