-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos boot extra-utils: ensure we use working lvm2 #96290
Conversation
This fixes the problem for me, though it's a bit hacky that we basically re-link cryptsetup to a different lvm2 "version". The recursion probably isn't needed now, but I think theoretically it might be useful. Also show those more results/failures in the build log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am able to run nixos tests again
For initrd, it probably doesn't matter much which lvm2 we use, as systemd isn't available there. |
The problem was that if we use the less featurful one, |
I assume we currently only have one We might be able to just use |
@vcunat something like this:
|
Yes, sounds good from what I know. |
dmsetup was missing symbols. #96290 (comment)
since you pushed to master, we should probably push master to staging-next, staging-next to staging. Currently all other branches are broken |
already done 😉 |
dmsetup was missing symbols. NixOS#96290 (comment) (cherry picked from commit f6286de)
This fixes the problem for me, though it's a bit hacky that we basically
re-link cryptsetup to a different lvm2 "version".
The recursion probably isn't needed now, but I think theoretically
it might be useful.
Also show those more results/failures in the build log.
Motivation for this change
Fixes #96197.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)