Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unityhub: fix editor with versions >= 2020.1.3f1 not opening #96544

Merged
merged 1 commit into from Sep 9, 2020
Merged

unityhub: fix editor with versions >= 2020.1.3f1 not opening #96544

merged 1 commit into from Sep 9, 2020

Conversation

tesq0
Copy link
Contributor

@tesq0 tesq0 commented Aug 28, 2020

Motivation for this change

Unity with versions >= 2020.1.3f1 installed through unityhub would crash when trying to open. Turns out libxml2 was missing.

Things done
  • [ x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkg20001
Copy link
Member

mkg20001 commented Sep 9, 2020

Tested locally, editor works, merging

@mkg20001 mkg20001 merged commit aa685f5 into NixOS:master Sep 9, 2020
@mkg20001 mkg20001 mentioned this pull request Sep 9, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants