Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.tldextract: add missing setuptools_scm dependency #96607

Merged
merged 1 commit into from Aug 29, 2020

Conversation

emmanuelrosa
Copy link
Contributor

Motivation for this change

This change adds setuptools_scm as a dependency so that tldextract builds.

The build was failing because it was trying to dowload (presumably setuptools-scm) during the buildPhase, which of course is not allowed. Adding it as a dependency resolved the issue.

tldextract is a dependency of qutebrowser, which is working with this change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit e435c54 into NixOS:master Aug 29, 2020
@emmanuelrosa emmanuelrosa deleted the tldextract-setuptools-pr branch August 30, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants