Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navi: 2.9.0 -> 2.10.0 #96694

Merged
merged 1 commit into from Sep 7, 2020
Merged

navi: 2.9.0 -> 2.10.0 #96694

merged 1 commit into from Sep 7, 2020

Conversation

@cust0dian
Copy link
Contributor

@cust0dian cust0dian commented Aug 30, 2020

Motivation for this change

https://github.com/denisidoro/navi/releases/tag/v2.10.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cust0dian
Copy link
Contributor Author

@cust0dian cust0dian commented Aug 30, 2020

This release adds support for using output of tldr as a cheatsheet, but not all tldr clients are supported. Ideally, users would use tealdeer, but it requires managing cache — I'm not sure if it can be or should be addressed during packaging, or if we should leave it up to users to decide what tldr client to use?

@cust0dian cust0dian force-pushed the cust0dian:navi-2.10.0 branch from 5af182e to b7d93e0 Aug 31, 2020
@marsam marsam merged commit 7c6fda9 into NixOS:master Sep 7, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7d93e0"; rev="b7d93e03740026944d687e69c82348472c802776"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7d93e0"; rev="b7d93e03740026944d687e69c82348472c802776"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7d93e0"; rev="b7d93e03740026944d687e69c82348472c802776"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7d93e0"; rev="b7d93e03740026944d687e69c82348472c802776"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7d93e0"; rev="b7d93e03740026944d687e69c82348472c802776"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7d93e0"; rev="b7d93e03740026944d687e69c82348472c802776"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b7d93e0"; rev="b7d93e03740026944d687e69c82348472c802776"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
navi, navi.passthru.tests on aarch64-linux Success
Details
navi, navi.passthru.tests on x86_64-linux Success
Details
@cust0dian cust0dian deleted the cust0dian:navi-2.10.0 branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.