New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unifi-poller: add service and prometheus-exporter #96830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes I'd suggest, overall LGTM :)
nixos/modules/services/monitoring/prometheus/exporters/unifi-poller.nix
Outdated
Show resolved
Hide resolved
@lheckemann thanks for the pointers. 🙂 i'll update the pr tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with this software - I just want to mention that we shouldn't have any password
options, only passwordFile
like options please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While a little refactoring on the prometheus exporters side wouldn't be amiss (in order to allow the warnings to apply to prometheus-exporter use, not just standalone use of the poller), I think blocking this addition on said refactoring wouldn't make much sense.
I'm happy with how the other points have been addressed, so I'd be all for merging it — @aanderse is that alright with you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without understanding the software itself module LGTM 👍
allows the prometheus-exporters test abstraction to work with e.g. hyphenated exporter-names
thanks for all your help. |
Motivation for this change
also:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)