-
-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Qt 5.15 from the Plasma 5 closure #97456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested it and it worked. Would love to see this merged soon! |
Feel like this should be backported |
The stable branch actually needs something different, because we're going back to Qt 5.12. |
orivej
added a commit
to orivej/nixpkgs
that referenced
this pull request
Sep 11, 2020
ttuegel
added a commit
that referenced
this pull request
Sep 11, 2020
nixos/plasma5: fix build with hardware.bluetooth.enable after #97456
ttuegel
pushed a commit
to ttuegel/nixpkgs
that referenced
this pull request
Sep 11, 2020
…ixOS#97456 (cherry picked from commit 21b2900)
alapshin
added a commit
to alapshin/nixpkgs
that referenced
this pull request
Sep 14, 2020
Fix build with enabled colord service after NixOS#97456
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Plasma 5 is using Qt 5.14, but Qt 5.15 was in the closure because:
kdeFrameworks
packages were picked from the wrong version.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)