Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitoxide: 0.3.0 -> 0.4.0 #97893

Merged
merged 1 commit into from Sep 14, 2020
Merged

gitoxide: 0.3.0 -> 0.4.0 #97893

merged 1 commit into from Sep 14, 2020

Conversation

syberant
Copy link
Member

Motivation for this change

To update the package I'm maintaining.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only two small suggested changes.

pkgs/applications/version-management/gitoxide/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/gitoxide/default.nix Outdated Show resolved Hide resolved
@syberant
Copy link
Member Author

Applied and squashed, thanks for the feedback!

@syberant
gitoxide: 0.3.0 -> 0.4.0
2f6c1ea 
Add dependency on openssl.
danieldk
danieldk approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97893 1

1 package built:
  • gitoxide

@danieldk danieldk merged commit 16f13a9 into NixOS:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@syberant @danieldk