Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nushell: fix Darwin build #97943

Closed

Conversation

@happysalada
Copy link
Contributor

@happysalada happysalada commented Sep 14, 2020

Motivation for this change

darwin build was broken
https://hydra.nixos.org/build/126549705/nixlog/2

Things done

add missing dependencies.
a very similar fix was done on https://github.com/NixOS/nixpkgs/pull/96996/files by @danieldk

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@happysalada happysalada changed the title nushell: fix darwin build nushell: fix Darwin build Sep 14, 2020
@ofborg ofborg bot requested review from Br1ght0ne and marsam Sep 14, 2020
@danieldk
Copy link
Member

@danieldk danieldk commented Sep 14, 2020

We should probably land #97000 before we get ad-hoc fixes everywhere.

@danieldk danieldk mentioned this pull request Sep 14, 2020
10 tasks
@happysalada
Copy link
Contributor Author

@happysalada happysalada commented Sep 14, 2020

Cool, I'll close this for now then

@danieldk
Copy link
Member

@danieldk danieldk commented Sep 14, 2020

It is probably still necessary to add the zlib dependency. But since the change in staging modifies stdenv, it will probably require a lot of rebuilds to try. Maybe we should pick this up again when staging is merged into master?

@happysalada
Copy link
Contributor Author

@happysalada happysalada commented Sep 14, 2020

Sure, feel free to update here, I can rebase and give it a try.

@happysalada happysalada reopened this Sep 14, 2020
@marsam marsam mentioned this pull request Oct 2, 2020
10 tasks
@marsam marsam closed this in #99390 Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants