Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arpack: assert that blas and lapack are compatible #98501

Merged
merged 2 commits into from Oct 1, 2020
Merged

arpack: assert that blas and lapack are compatible #98501

merged 2 commits into from Oct 1, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 22, 2020 •
edited

Motivation for this change

Implement stuff I learned at https://savannah.gnu.org/bugs/?57591#comment112 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
arpack: cosmetic changes
e0d947c 
Don't use `with stdenv.lib` at the top of the expression, per:
https://nix.dev/anti-patterns/language.html#with-attrset-expression

Use rec and version inside `mkDerivation`, like almost any other
derivation.
@doronbehar
arpack: assert that blas and lapack are compatible
bd77df6 
Do it before buildInputs per:
NixOS#94892 (comment)

Remove unneed, BLAS_LIBS and LAPACK_LIBS from environment - the
libraries are detected just fine when in buildInputs.
@ofborg ofborg bot requested a review from ttuegel September 22, 2020 23:00
@doronbehar doronbehar merged commit 60b4b39 into NixOS:master Oct 1, 2020
@doronbehar doronbehar deleted the pkg/octave/arpack branch October 1, 2020 16:04
@doronbehar
Copy link
Contributor Author

Thanks :).

@doronbehar doronbehar mentioned this pull request Oct 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @ttuegel