Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joplin-desktop: 1.0.245 -> 1.1.4 #98584

Merged
merged 1 commit into from Sep 30, 2020
Merged

joplin-desktop: 1.0.245 -> 1.1.4 #98584

merged 1 commit into from Sep 30, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Sep 23, 2020

Motivation for this change
  • update to 1.1.4 (changelog)
  • enable on darwin
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

HugoReeves
HugoReeves approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@HugoReeves HugoReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. There are a lot of changes here and I'm currently unable to test on any Linux system. Provided all the automated tests are passing, and this builds successfully on Linux, I'm ok with this being merged. LGTM

@infinisil infinisil merged commit 098dedb into NixOS:master Sep 30, 2020
@sikmir sikmir deleted the joplin branch September 30, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoReeves HugoReeves HugoReeves approved these changes

@stigtsp stigtsp Awaiting requested review from stigtsp

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @HugoReeves @infinisil