Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tlp: Add support for non-x86 platforms #98618

Merged
merged 1 commit into from Oct 20, 2020
Merged

tlp: Add support for non-x86 platforms #98618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/tools/misc/tlp/default.nix
View file
Open in desktop
Expand Up @@ -87,8 +87,8 @@
smartmontools
systemd
utillinux
x86_energy_perf_policy
] ++ lib.optional enableRDW networkmanager
++ lib.optional (lib.any (lib.meta.platformMatch stdenv.hostPlatform) x86_energy_perf_policy.meta.platforms) x86_energy_perf_policy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need lib.any here? Why not just x86_energy_perf_policy.meta.platforms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention was to say that if the current platform matches any of the platforms supported by x86_energy_perf_policy, then include it, otherwise don't. So I guess lib.any is there because there are multiple platforms in x86_energy_perf_policy.meta.platforms.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, approved!

);
in
''
Expand Down