Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shebang for binaries in JRuby #98693

Merged
merged 1 commit into from Sep 25, 2020
Merged

Commits on Sep 25, 2020

  1. jruby: fix shebang for binaries in JRuby

    There are a variety of additional scripts that are included with the
    JRuby installation that use JRuby itself.
    
    For instance the `bin/gem` had the following contents:
    
    ```bash
    ❯ cat /nix/store/kglkqf56ii83yl6yrgcaj5r3s9m2fzr0-jruby-9.2.13.0/bin/gem
    
    load File.join(File.dirname(__FILE__), 'jgem')
    ```
    
    This is clearly wrong. Patchshebangs was not picking up the fix as part
    of stdenv because the patch is not a build input but the final output
    itself.
    
    We have to rely on substituteInPlace so that we get the correct version.
    
    ```bash
    ❯ cat /nix/store/k4fnrn0dcsh2wzw81217r0ywsspb468f-jruby-9.2.13.0/bin/gem
    
    ```
    fzakaria committed Sep 25, 2020
    Copy the full SHA
    8da7bd6 View commit details
    Browse the repository at this point in the history