Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidiabl: 2017-09-26 -> 2020-10-01 (fix build) #99252

Merged
merged 1 commit into from Oct 11, 2020

Conversation

@yorickvP
Copy link
Contributor

@yorickvP yorickvP commented Oct 1, 2020

Motivation for this change

The Linux API changed slightly, removing ioremap_nocache from Linux >= 5.7. It may be time to deprecate this module soon, but this fix is easy enough. This fixes 8 hydra failures.

ZHF: #97479
@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes build on linux >= 5.7
@yorickvP
Copy link
Contributor Author

@yorickvP yorickvP commented Oct 1, 2020

@ofborg build linuxPackages_5_4.nvidiabl linuxPackages_5_7.nvidiabl linuxPackages_5_8.nvidiabl linuxPackages_latest.nvidiabl linuxPackages_latest-libre.nvidiabl linuxPackages_latest_hardened.nvidiabl linuxPackages_latest_xen_dem0.nvidiabl linuxPackages_latest_hardened_xen_dem0.nvidiabl linuxPackages_zen.nvidiabl

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99252 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.nvidiabl
  • linuxPackages_hardkernel_latest.nvidiabl
17 packages built:
  • linuxPackages-libre.nvidiabl
  • linuxPackages.nvidiabl (linuxPackages_5_4.nvidiabl)
  • linuxPackages_4_14.nvidiabl
  • linuxPackages_4_19.nvidiabl
  • linuxPackages_4_4.nvidiabl
  • linuxPackages_4_9.nvidiabl
  • linuxPackages_5_7.nvidiabl
  • linuxPackages_5_8.nvidiabl (linuxPackages_latest.nvidiabl)
  • linuxPackages_hardened.nvidiabl
  • linuxPackages_latest-libre.nvidiabl
  • linuxPackages_latest_hardened.nvidiabl
  • linuxPackages_latest_xen_dom0.nvidiabl
  • linuxPackages_latest_xen_dom0_hardened.nvidiabl
  • linuxPackages_testing_bcachefs.nvidiabl
  • linuxPackages_xen_dom0.nvidiabl
  • linuxPackages_xen_dom0_hardened.nvidiabl
  • linuxPackages_zen.nvidiabl

@jonringer jonringer merged commit f491c18 into NixOS:master Oct 11, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
linuxPackages_5_4.nvidiabl, linuxPackages_5_7.nvidiabl, linuxPackages_5_8.nvidiabl, linuxPackages_latest-libre.nvidiabl, linuxPackages_latest.nvidiabl, linuxPackages_latest_hardened.nvidiabl, linuxPackages_latest_hardened_xen_dem0.nvidiabl, linuxPackages_latest_xen_dem0.nvidiabl, linuxPackages_zen.nvidiabl on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21846bc"; rev="21846bc66e70dd9c2ef121eaf1466f10207eb547"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21846bc"; rev="21846bc66e70dd9c2ef121eaf1466f10207eb547"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21846bc"; rev="21846bc66e70dd9c2ef121eaf1466f10207eb547"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21846bc"; rev="21846bc66e70dd9c2ef121eaf1466f10207eb547"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21846bc"; rev="21846bc66e70dd9c2ef121eaf1466f10207eb547"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21846bc"; rev="21846bc66e70dd9c2ef121eaf1466f10207eb547"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21846bc"; rev="21846bc66e70dd9c2ef121eaf1466f10207eb547"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
linuxPackages_5_4.nvidiabl, linuxPackages_5_7.nvidiabl, linuxPackages_5_8.nvidiabl, linuxPackages_latest-libre.nvidiabl, linuxPackages_latest.nvidiabl, linuxPackages_latest_hardened.nvidiabl, linuxPackages_latest_hardened_xen_dem0.nvidiabl, linuxPackages_latest_xen_dem0.nvidiabl, linuxPackages_zen.nvidiabl on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants