Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openrct2: 0.3.0 -> 0.3.2 #99326

Merged
merged 2 commits into from Nov 24, 2020
Merged

openrct2: 0.3.0 -> 0.3.2 #99326

merged 2 commits into from Nov 24, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Oct 1, 2020

Motivation for this change

Update OpenRCT2 to its latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak approved these changes Oct 3, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works

prusnak
prusnak requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile v0.3.2 was released. Will you update this PR please?

@oxzi oxzi changed the title openrct2: 0.3.0 -> 0.3.1 openrct2: 0.3.0 -> 0.3.2 Nov 24, 2020
@oxzi
Copy link
Member Author

oxzi commented Nov 24, 2020

@prusnak: Thanks for checking back again. I have updated the PR.

@prusnak prusnak merged commit ffcf28a into NixOS:master Nov 24, 2020
@oxzi oxzi deleted the openrct2-v0.3.1 branch November 24, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxzi @prusnak