Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumble-overlay: fix outdated install phase #99337

Merged
merged 1 commit into from Oct 2, 2020
Merged

mumble-overlay: fix outdated install phase #99337

merged 1 commit into from Oct 2, 2020

Conversation

@ldesgoui
Copy link
Contributor

@ldesgoui ldesgoui commented Oct 1, 2020

As it stands, the mumble-overlay install phase attemps to link
{mumble}/lib/libmumble.so.1.2.* to its output's lib/libmumble.so.1,
this has stopped matching any file ever since mumble has passed
version 1.3.
Instead, we simply link from {mumble}/lib/libmumble.so.1

Motivation for this change

Fixes https://hydra.nixos.org/build/128015584
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
As it stands, the mumble-overlay install phase attemps to link
`{mumble}/lib/libmumble.so.1.2.*` to its output's `lib/libmumble.so.1`,
this has stopped matching any file ever since mumble has passed
version 1.3.
Instead, we simply link from `{mumble}/lib/libmumble.so.1`
@Infinisil Infinisil merged commit c04277e into NixOS:master Oct 2, 2020
17 checks passed
@ldesgoui ldesgoui deleted the fix-mumble_overlay branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants