Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/device-tree: fix cross compilation for _rpi kernels #99378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@sorki
Copy link
Member

@sorki sorki commented Oct 2, 2020

Motivation for this change

Fixes issues with linuxPackages_rpi variants like #79370 (comment)

Instead of just ARCH pass all makeFlags like upstream linux derivation does.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 2, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cross-compiling-problem-with-devicetree-on-armv6/9254/2

@CRTified
Copy link
Contributor

@CRTified CRTified commented Oct 26, 2020

This PR solves the cross-compiling problem for at least one devicetree overlays (as discussed in the discourse thread), so from my side it would make sense to merge it. (Right now using it with a local checkout that is rebased onto master).

@flokli
Copy link
Contributor

@flokli flokli commented Jan 10, 2021

Is this still a problem? So far, I've successfully cross-compiled device tree overlays (not with the _rpi kernel), but for a Pine64 on the mainline kernel.

@CRTified
Copy link
Contributor

@CRTified CRTified commented Jan 18, 2021

@flokli I think this is still a problem. I did not have time to test it again, but if I recall correctly the problem was relatively specific to the RPi zero (so armv6). I don't have time right now to test it again, but as the file changed by this PR did not change on master, I'd suspect that the problem also exists.

It should be simple to test whether this problem is gone, as I've provided a minimal working example config in the discourse referenced above. I'll see if I find some time today to run it against master and report back.

@stale
Copy link

@stale stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants