Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

starboard: init at 0.4.0 #99412

Merged
merged 1 commit into from Oct 13, 2020
Merged

starboard: init at 0.4.0 #99412

merged 1 commit into from Oct 13, 2020

Conversation

@06kellyjac
Copy link
Contributor

@06kellyjac 06kellyjac commented Oct 2, 2020

Motivation for this change

Add the starboard k8s security toolkit to nixpkgs

I've categorized it in applications/networking/cluster as most k8s tools go there but I'm open to moving it if there are better suggestions.

Version is set but might check what the official release looks like. Might set the date to Unix epoch or N/A 馃し
Starboard Version: {Version:v0.4.0 Commit:none Date:unknown}

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions (aarch64 archlinux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/316

@06kellyjac 06kellyjac force-pushed the 06kellyjac:init_starboard branch from bd9cb64 to 72fce3d Oct 13, 2020
@06kellyjac 06kellyjac requested a review from AndersonTorres Oct 13, 2020
@06kellyjac 06kellyjac force-pushed the 06kellyjac:init_starboard branch from 72fce3d to fa4c326 Oct 13, 2020
Copy link
Member

@AndersonTorres AndersonTorres left a comment

LGTM, LGTBorg

@AndersonTorres AndersonTorres merged commit 1e70a76 into NixOS:master Oct 13, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa4c326"; rev="fa4c32628d84cc66e2dd9ae4447b60c160179d4a"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa4c326"; rev="fa4c32628d84cc66e2dd9ae4447b60c160179d4a"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa4c326"; rev="fa4c32628d84cc66e2dd9ae4447b60c160179d4a"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa4c326"; rev="fa4c32628d84cc66e2dd9ae4447b60c160179d4a"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa4c326"; rev="fa4c32628d84cc66e2dd9ae4447b60c160179d4a"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa4c326"; rev="fa4c32628d84cc66e2dd9ae4447b60c160179d4a"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fa4c326"; rev="fa4c32628d84cc66e2dd9ae4447b60c160179d4a"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
starboard, starboard.passthru.tests on aarch64-linux Success
Details
@ofborg
starboard, starboard.passthru.tests on x86_64-linux Success
Details
@06kellyjac 06kellyjac deleted the 06kellyjac:init_starboard branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants