Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron updates #99421

Merged
merged 4 commits into from Nov 1, 2020
Merged

Electron updates #99421

merged 4 commits into from Nov 1, 2020

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented Oct 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
prusnak added 4 commits Oct 15, 2020
to make it more usable for automated update
@prusnak prusnak force-pushed the prusnak:electron branch from 755df14 to 0743d15 Oct 28, 2020
@prusnak
Copy link
Member Author

@prusnak prusnak commented Oct 28, 2020

Update to recent versions 9.3.3 and 10.1.5

@ajs124
ajs124 approved these changes Oct 28, 2020
@srhb
Copy link
Contributor

@srhb srhb commented Oct 31, 2020

@ofborg build

Trying to nudge for the stalled darwin build.

@gebner gebner merged commit f183291 into NixOS:master Nov 1, 2020
19 of 20 checks passed
19 of 20 checks passed
tests
Details
action
Details
electron, electron.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
electron, electron.passthru.tests on aarch64-linux Success
Details
electron, electron.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0743d15"; rev="0743d1591fee55aee74d98b1395b17e102dc98bc"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0743d15"; rev="0743d1591fee55aee74d98b1395b17e102dc98bc"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0743d15"; rev="0743d1591fee55aee74d98b1395b17e102dc98bc"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0743d15"; rev="0743d1591fee55aee74d98b1395b17e102dc98bc"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0743d15"; rev="0743d1591fee55aee74d98b1395b17e102dc98bc"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0743d15"; rev="0743d1591fee55aee74d98b1395b17e102dc98bc"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0743d15"; rev="0743d1591fee55aee74d98b1395b17e102dc98bc"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@prusnak prusnak deleted the prusnak:electron branch Nov 1, 2020
@prusnak prusnak mentioned this pull request Nov 1, 2020
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.