Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilem: init at 2.0 #99572

Merged
merged 1 commit into from Oct 16, 2020
Merged

tilem: init at 2.0 #99572

merged 1 commit into from Oct 16, 2020

Conversation

@siraben
Copy link
Contributor

@siraben siraben commented Oct 4, 2020

Motivation for this change

Add tilem emulator

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

For tilibs, you should prolly fetch them from the upstream project instead.

https://sourceforge.net/projects/tilp/files/tilp2-linux/tilp2-1.18/

pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
@siraben siraben force-pushed the siraben:tilem-init branch 2 times, most recently from a702147 to cd4b859 Oct 5, 2020
@siraben siraben requested review from OPNA2608 and symphorien Oct 11, 2020
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

You'll wanna set meta.platforms to whatever platforms this package is supposed to be available on, and you might wanna run this through nixpkgs-fmt. Do you think/know if those libraries are used in any other projects? LGTM otherwise.

@siraben siraben force-pushed the siraben:tilem-init branch from cd4b859 to 81ef443 Oct 11, 2020
@siraben
Copy link
Contributor Author

@siraben siraben commented Oct 11, 2020

Just ran it through nixpkgs-fmt, and set meta.platforms = platforms.linux ++ platforms.darwin;. I don't think the libraries are used in any other projects ATM, if they were in the future, should I make separate derivations for the libraries?

Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Tested on Ubuntu 18.04, binary builds & launches, though I can't test beyond the ROM selection dialogue. Don't think I have the permissions to kick off a x86_64-darwin build on ofborg (and they recently seem to get stuck anyway?) so that unfortunately goes untested.

I don't think the libraries are used in any other projects ATM, if they were in the future, should I make separate derivations for the libraries?

I think it'd make sense to do it now, to avoiding accidental repackages later on or if a user needs only those libraries locally. IMO as it is seems acceptable to me too since they're fairly specific to the application, so I'll leave it up to you. LGTM

@siraben
Copy link
Contributor Author

@siraben siraben commented Oct 13, 2020

I tested on x86_64-darwin and NixOS, it runs as expected when given a ROM (e.g. https://github.com/siraben/zkeme80).

IMO as it is seems acceptable to me too since they're fairly specific to the application, so I'll leave it up to you.

I think it's ready for merge then!

@siraben siraben requested a review from OPNA2608 Oct 13, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 13, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/335

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 13, 2020

Whoops, wrong thread…

requested a review

Don't have merge permissions, sorry. Can only forward the PR to somehow who does.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 13, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/246

@AndersonTorres AndersonTorres merged commit 4669a06 into NixOS:master Oct 16, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81ef443"; rev="81ef443d05db901e0105be0b4a91a883640b23ce"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81ef443"; rev="81ef443d05db901e0105be0b4a91a883640b23ce"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81ef443"; rev="81ef443d05db901e0105be0b4a91a883640b23ce"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81ef443"; rev="81ef443d05db901e0105be0b4a91a883640b23ce"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81ef443"; rev="81ef443d05db901e0105be0b4a91a883640b23ce"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81ef443"; rev="81ef443d05db901e0105be0b4a91a883640b23ce"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="81ef443"; rev="81ef443d05db901e0105be0b4a91a883640b23ce"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tilem, tilem.passthru.tests on aarch64-linux Success
Details
tilem, tilem.passthru.tests on x86_64-linux Success
Details
@siraben siraben deleted the siraben:tilem-init branch Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.