Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: make fstab owner/user/users mount options assert setuid mount/umount #9998

Closed
wants to merge 1 commit into from
Closed

nixos: make fstab owner/user/users mount options assert setuid mount/umount #9998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions nixos/modules/tasks/filesystems.nix
View file
Open in desktop
Expand Up @@ -134,6 +134,22 @@ in

config = {

assertions = [
{ assertion =
any (fs: [] != intersectLists (splitString "," fs.options)
[ "owner" "user" "users" ])
fileSystems
-> all (x: elem x config.security.setuidPrograms)
[ "mount" "umount" ];
message = ''
The fstab "owner", "user", and "users" options require "mount" and "umount"
to be setuid. Please add the following to your system configuration:

security.setuidPrograms = [ "mount" "umount" ];
'';
}
];

boot.supportedFilesystems = map (fs: fs.fsType) fileSystems;

# Add the mount helpers to the system path so that `mount' can find them.
Expand Down