move lib-tests to a build #511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still has problems with rebuilds since it uses the target nixpkgs to build the tests, but it's a regular build job which doesn't block the entire evaluator anymore. Mitigates the main problem until we decide what to do for these kind of use cases.
|
See #472 which I think is a good solution in this specific case, since the lib tests only need some very basic builders from pkgs |
cole-h
approved these changes
Jun 17, 2020
|
Not sure there's anything specific, but #513 is probably most relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still has problems with rebuilds since it uses the target nixpkgs
to build the tests, but it's a regular build job which doesn't block the
entire evaluator anymore. Mitigates the main problem until we decide
what to do for these kind of use cases.