Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the beta phase #42

Merged
merged 2 commits into from May 29, 2022
Merged

Document the beta phase #42

merged 2 commits into from May 29, 2022

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented May 26, 2022

cc @mweinelt, @vcunat, @cole-h because you reviewed my last PR as well.
Maybe there's something to mention that I forgot? I don't plan to merge this until 1-2 days before the release

# Beta Phase

- Monitor the master branch for bugfixes and minor updates and
cherry-pick them to the release branch.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I forgot is NixOS/nixpkgs#173671 but I don't really know how to phrase this and when to do it. Do you have any idea, @Mindavi? You starting around the time of branch-off is probably good to get done in time. Also related to #4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past, I believe this has been done one evaluation before official release, but I may be mistaken. That way ZHF fixes can be accepted until the very last second.

Copy link

@Mindavi Mindavi May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it makes sense to do it at the very last moment. Would be nice if we could get a script or something going, but it seems like that might be some more work than I have time for now.

I think it could make sense to just mark them all and then drop any commits that are not applicable anymore.

But yeah, definitely figuring out the process myself too. Any process description is probably better than none :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, could definitely be useful! (Though it doesn't take into account different platforms, but we may be able to build that easily-ish 😁)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit that explains that this has to be done in the beta phase, linking to #4 and this discussion.
If nobody has anything to add here, I'd say we merge as-is and continue the discussion in #4

@dasJ dasJ merged commit 82bf761 into master May 29, 2022
@dasJ dasJ deleted the feat/beta-phase branch May 29, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants