Merge upstream changes 2 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a small change, but I find it more readable.
This more accurately reflects our intent. With `nullable` the value must decode exactly, or be `null`. With `maybe` the value must decode exactly, you get a `Nothing` even if total junk is present.
Fixed compilation warnings.
Like all the cool kids are doing these days. :-)
Fix HasDecoder ElmValue
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the work on the development branch of the krisajenkins repo, plus the work towards supporting ADT's from this PR: krisajenkins#34
This solves addressed some issues towards to generation of newtype encoders I was looking at. Further issues remain though: the generated code for newtype decoders doesn't appear to be valid.
This is the same as #1 but without the accidental formatting changes incurred by running hindent.