Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ETag feature #21

Merged
merged 8 commits into from
Nov 9, 2018
Merged

Rework ETag feature #21

merged 8 commits into from
Nov 9, 2018

Conversation

lafrech
Copy link
Member

@lafrech lafrech commented Nov 4, 2018

Extract ETag feature in a separate mixin to decouple it from response marshmaling.

Main changes:

  • Etag is now managed from a new @etag decorator.
  • check_etag and set_etag are methods of EtagMixin, therefore of Blueprint.
  • No need to use disable_etag_for_request: just don't use @etag decorator.
  • List of headers to include in ETag computation is configurable in Blueprint.ETAG_INCLUDE_HEADERS.

TODO:

  • Changelog
  • Docs
  • Replace ETAG_ENABLED config variable with ETAG_DISABLED (à la flask-login)?

@coveralls
Copy link

coveralls commented Nov 4, 2018

Coverage Status

Coverage increased (+0.2%) to 99.82% when pulling 3652561 on dev_rework_response_etag into 304bc0f on master.

@lafrech lafrech changed the title WIP - Rework ETag feature Rework ETag feature Nov 9, 2018
@lafrech lafrech merged commit 6755d3b into master Nov 9, 2018
@lafrech lafrech deleted the dev_rework_response_etag branch November 9, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants